Skip to content

Remove obsolete TODOs #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Remove obsolete TODOs #314

merged 1 commit into from
Nov 5, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 5, 2021

This PR

  • removes a few obsolete TODO items from the "Purpose and Scope" section of the specification. The first TODO pertains to the initial RFC and can be removed now that the standard is moving toward official release. The second and third TBDs concern optional extensions. As the linalg extension has been added, it provides a cowpath for subsequent extensions and demonstrates how extensions are included in the standard.

@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content. labels Nov 5, 2021
@kgryte kgryte added this to the v2021 milestone Nov 5, 2021
@kgryte
Copy link
Contributor Author

kgryte commented Nov 5, 2021

cc @rgommers One thing that may need to change is the figure in the "in scope" section. This currently says TBD.

And one consideration not addressed in the specification is whether extensions can be versioned independently of the main (non-extension) namespace. Atm, the linalg extension resides in a separate sub-namespace, and the specification is not clear on whether the linalg sub-namespace should also include a version. We may want to make that more clear.

@kgryte kgryte merged commit f4c8c7f into main Nov 5, 2021
@kgryte kgryte deleted the remove-todos branch November 5, 2021 05:46
@rgommers
Copy link
Member

rgommers commented Nov 5, 2021

One thing that may need to change is the figure in the "in scope" section. This currently says TBD.

I'll update that figure.

And one consideration not addressed in the specification is whether extensions can be versioned independently of the main (non-extension) namespace. Atm, the linalg extension resides in a separate sub-namespace, and the specification is not clear on whether the linalg sub-namespace should also include a version. We may want to make that more clear.

I'd say no, it's just optional but it's not a completely separate thing with its own versioning scheme.

@kgryte
Copy link
Contributor Author

kgryte commented Nov 5, 2021

I'll update that figure.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants